build/common.gypi - Issue 1577433004: Flip proprietary codecs to false for Android chromium builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1577433004: Flip proprietary codecs to false for Android chromium builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo comment change. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index a73eb1be2326fc078a816366fdf1d0ab0663f584..32daaf2f4dca6b568805f72f3ea159323429ea66 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -833,10 +833,9 @@

'use_browser_spellchecker%': 1,

}],

- # Android OS includes support for proprietary codecs regardless of

- # building Chromium or Google Chrome. We also ship Google Chrome and

- # Chromecast with proprietary codecs.

- ['OS=="android" or branding=="Chrome" or chromecast==1', {

+ # Enables proprietary codecs and demuxers; e.g. H264, AAC, MP3, and MP4.

+ # We always build Google Chrome and Chromecast with proprietary codecs.

+ ['branding=="Chrome" or chromecast==1', {

'proprietary_codecs%': 1,

}, {

'proprietary_codecs%': 0,

« no previous file with comments | « build/android/gyp/apkbuilder.py ('k') | build/config/features.gni » ('j') | no next file with comments »