build/android/gyp/apkbuilder.py - Issue 1577433004: Flip proprietary codecs to false for Android chromium builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/apkbuilder.py

Issue 1577433004: Flip proprietary codecs to false for Android chromium builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix apk builder for webm. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/apkbuilder.py

diff --git a/build/android/gyp/apkbuilder.py b/build/android/gyp/apkbuilder.py

index cba311f08d72409ee9595cc0a0e3326c8b089eaf..16e863c7940c9f9ae2cf45194adb4d9f62096151 100755

--- a/build/android/gyp/apkbuilder.py

+++ b/build/android/gyp/apkbuilder.py

@@ -16,12 +16,12 @@ import zipfile

from util import build_utils

-# Taken from aapt's Package.cpp:

+# Taken mostly from aapt's Package.cpp. Additionally includes ".webm"

jbudorick 2016/03/12 00:46:10 nit: undo this change

DaleCurtis 2016/03/12 00:49:16 Done.

_NO_COMPRESS_EXTENSIONS = ('.jpg', '.jpeg', '.png', '.gif', '.wav', '.mp2',

'.mp3', '.ogg', '.aac', '.mpg', '.mpeg', '.mid',

'.midi', '.smf', '.jet', '.rtttl', '.imy', '.xmf',

'.mp4', '.m4a', '.m4v', '.3gp', '.3gpp', '.3g2',

- '.3gpp2', '.amr', '.awb', '.wma', '.wmv')

+ '.3gpp2', '.amr', '.awb', '.wma', '.wmv', '.webm')

def _ParseArgs(args):

« no previous file with comments | « android_webview/test/shell/assets/video.webm ('k') | build/common.gypi » ('j') | no next file with comments »