Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: media/media.gyp

Issue 1577433004: Flip proprietary codecs to false for Android chromium builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove mp4. Fix comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/android/BUILD.gn ('K') | « media/filters/audio_decoder_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/media.gyp
diff --git a/media/media.gyp b/media/media.gyp
index 071444aa8bc69929d7326efbe8776587fe3fab4e..932e55c883541d105a487bc46f7c66867663a0c0 100644
--- a/media/media.gyp
+++ b/media/media.gyp
@@ -1159,7 +1159,6 @@
'<@(capture_unittests_sources)',
'base/android/access_unit_queue_unittest.cc',
'base/android/media_codec_decoder_unittest.cc',
- 'base/android/media_codec_player_unittest.cc',
'base/android/media_drm_bridge_unittest.cc',
'base/android/media_player_bridge_unittest.cc',
'base/android/media_source_player_unittest.cc',
@@ -1329,12 +1328,6 @@
'filters/ffmpeg_video_decoder_unittest.cc',
'test/pipeline_integration_test.cc',
'test/pipeline_integration_test_base.cc',
ddorwin 2016/03/10 01:46:39 Update media/BUILD.gn too.
DaleCurtis 2016/03/10 02:00:02 Whoops, not sure how that got dropped.
-
- # These tests are confused by Android always having proprietary
- # codecs enabled, but ffmpeg_branding=Chromium. These should be
- # fixed, see http://crbug.com/570762.
- 'filters/audio_file_reader_unittest.cc',
- 'filters/ffmpeg_demuxer_unittest.cc',
],
}],
['OS=="android"', {
@@ -1368,6 +1361,7 @@
}],
['proprietary_codecs==1', {
'sources': [
+ 'base/android/media_codec_player_unittest.cc',
ddorwin 2016/03/10 01:46:39 ditto
DaleCurtis 2016/03/10 02:00:02 This is already done above in media/base/android/B
ddorwin 2016/03/10 02:03:36 I meant ditto for a comment/bug/TODO. :) That wasn
'cdm/cenc_utils_unittest.cc',
'filters/ffmpeg_aac_bitstream_converter_unittest.cc',
'filters/ffmpeg_h264_to_annex_b_bitstream_converter_unittest.cc',
« media/base/android/BUILD.gn ('K') | « media/filters/audio_decoder_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698