Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: build/common.gypi

Issue 1577433004: Flip proprietary codecs to false for Android chromium builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove mp4. Fix comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 815 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 'enable_print_preview%': 0, 826 'enable_print_preview%': 0,
827 'enable_task_manager%':0, 827 'enable_task_manager%':0,
828 'video_hole%': 1, 828 'video_hole%': 1,
829 }], 829 }],
830 830
831 # Android and OSX have built-in spellcheckers that can be utilized. 831 # Android and OSX have built-in spellcheckers that can be utilized.
832 ['OS=="android" or OS=="mac"', { 832 ['OS=="android" or OS=="mac"', {
833 'use_browser_spellchecker%': 1, 833 'use_browser_spellchecker%': 1,
834 }], 834 }],
835 835
836 # Android OS includes support for proprietary codecs regardless of 836 # Enables proprietary codecs and demuxers; e.g. H264, MOV, AAC, and MP3.
ddorwin 2016/03/10 01:46:38 nit: MOV as in the container? Use MP4 instead? I a
DaleCurtis 2016/03/10 02:00:02 Done.
837 # building Chromium or Google Chrome. We also ship Google Chrome and 837 # We always build Google Chrome and Chromecast with proprietary codecs.
838 # Chromecast with proprietary codecs. 838 ['branding=="Chrome" or chromecast==1', {
839 ['OS=="android" or branding=="Chrome" or chromecast==1', {
840 'proprietary_codecs%': 1, 839 'proprietary_codecs%': 1,
841 }, { 840 }, {
842 'proprietary_codecs%': 0, 841 'proprietary_codecs%': 0,
843 }], 842 }],
844 843
845 # Enable autofill dialog when not on iOS. 844 # Enable autofill dialog when not on iOS.
846 ['OS!="ios"', { 845 ['OS!="ios"', {
847 'enable_autofill_dialog%': 1, 846 'enable_autofill_dialog%': 1,
848 }], 847 }],
849 848
(...skipping 5504 matching lines...) Expand 10 before | Expand all | Expand 10 after
6354 # settings in target dicts. SYMROOT is a special case, because many other 6353 # settings in target dicts. SYMROOT is a special case, because many other
6355 # Xcode variables depend on it, including variables such as 6354 # Xcode variables depend on it, including variables such as
6356 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6355 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6357 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6356 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6358 # files to appear (when present) in the UI as actual files and not red 6357 # files to appear (when present) in the UI as actual files and not red
6359 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6358 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6360 # and therefore SYMROOT, needs to be set at the project level. 6359 # and therefore SYMROOT, needs to be set at the project level.
6361 'SYMROOT': '<(DEPTH)/xcodebuild', 6360 'SYMROOT': '<(DEPTH)/xcodebuild',
6362 }, 6361 },
6363 } 6362 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698