third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp - Issue 1577433003: Statistics of LayoutBox rare data reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

Issue 1577433003: Statistics of LayoutBox rare data reasons Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

index 8fbeb7903c1321cc5b881a20f898a017e4541e4c..dcb1a97569607f296b8fc1f93b07e5c84a8c05bc 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

@@ -109,6 +109,16 @@ void LayoutSVGForeignObject::layout() {

setX(elementX());

setY(elementY());

+ if (location() != LayoutPoint()) {

+ for (auto* o = firstChild(); o; o = o->nextInPreOrder(this)) {

+ if (o->isLayoutPart()) {

+ m_rareStat.addReason(ReasonLOSVGForeignBug);

+ LOG(ERROR) << "Found SVG Foreign bug";

+ break;

+ }

bool layoutChanged = everHadLayout() && selfNeedsLayout();

LayoutBlock::layout();

ASSERT(!needsLayout());