Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tool/input_sdk/lib/html/ddc/html_ddc.dart

Issue 1577423002: Added Comment to dart:html (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/collection/wrappers.txt ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/html/ddc/html_ddc.dart
diff --git a/tool/input_sdk/lib/html/ddc/html_ddc.dart b/tool/input_sdk/lib/html/ddc/html_ddc.dart
index 670f45e834a9217ba2bbd5533a38366e6cef54af..8843384eed9d8b27ff36d3cf28854d575f23dd79 100644
--- a/tool/input_sdk/lib/html/ddc/html_ddc.dart
+++ b/tool/input_sdk/lib/html/ddc/html_ddc.dart
@@ -462,6 +462,34 @@ abstract class ChildNode extends DartHtmlDomObject {
// BSD-style license that can be found in the LICENSE file.
+@DocsEditable()
+@DomName('Comment')
+@Native("Comment")
+class Comment extends CharacterData {
+ factory Comment([String data]) {
+ if (data != null) {
+ return wrap_jso(JS('Comment', '#.createComment(#)', document.raw, data));
+ }
+ return wrap_jso(JS('Comment', '#.createComment("")', document.raw));
+ }
+ // To suppress missing implicit constructor warnings.
+ factory Comment._() { throw new UnsupportedError("Not supported"); }
+
+
+ @Deprecated("Internal Use Only")
+ static Comment internalCreateComment() {
+ return new Comment.internal_();
+ }
+
+ @Deprecated("Internal Use Only")
+ Comment.internal_() : super.internal_();
+
+}
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+
@DomName('Console')
class Console extends DartHtmlDomObject {
@@ -19434,7 +19462,7 @@ wrap_jso(jso) {
name = JS('String', '#.name', constructor);
f = getHtmlCreateFunction(name);
if (f == null) {
- console.warn('Could not instantiate $name');
+ console.error('Could not instantiate $name');
skip = true;
constructor = JS('', '#.__proto__', constructor);
}
@@ -19465,6 +19493,7 @@ final htmlBlinkMap = {
'CharacterData': () => CharacterData,
'ChildNode': () => ChildNode,
'ClientRect': () => _ClientRect,
+ 'Comment': () => Comment,
'Console': () => Console,
'ConsoleBase': () => ConsoleBase,
'DOMImplementation': () => DomImplementation,
@@ -19514,6 +19543,7 @@ final htmlBlinkFunctionMap = {
'CSSStyleDeclaration': () => CssStyleDeclaration.internalCreateCssStyleDeclaration,
'CharacterData': () => CharacterData.internalCreateCharacterData,
'ClientRect': () => _ClientRect.internalCreate_ClientRect,
+ 'Comment': () => Comment.internalCreateComment,
'Console': () => Console.internalCreateConsole,
'ConsoleBase': () => ConsoleBase.internalCreateConsoleBase,
'DOMImplementation': () => DomImplementation.internalCreateDomImplementation,
« no previous file with comments | « test/codegen/expect/collection/wrappers.txt ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698