Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1577413002: Patch together getters/setters in different parts. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch together getters/setters in different parts. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2f57161e74e79632f7c069c20575cb3a899c6669

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -158 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 5 chunks +166 lines, -109 lines 1 comment Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +1 line, -49 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +16 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-12 20:27:46 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1577413002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1577413002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode6794 pkg/analyzer/lib/src/generated/resolver.dart:6794: * Instances of the class `LibraryResolver` are used ...
4 years, 11 months ago (2016-01-13 16:12:01 UTC) #2
scheglov
4 years, 11 months ago (2016-01-13 16:26:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f57161e74e79632f7c069c20575cb3a899c6669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698