Fixed problem with clicking on app launcher item

ui/app_list/views/apps_grid_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/apps_grid_view.h"
 
 #include <algorithm>
 
 #include "ui/app_list/app_list_item_model.h"
 #include "ui/app_list/apps_grid_view_delegate.h"
 #include "ui/app_list/pagination_model.h"
 #include "ui/app_list/views/app_list_drag_and_drop_host.h"
 #include "ui/app_list/views/app_list_item_view.h"
 #include "ui/app_list/views/page_switcher.h"
 #include "ui/app_list/views/pulsing_block_view.h"
 #include "ui/base/animation/animation.h"
 #include "ui/base/events/event.h"
+#include "ui/compositor/scoped_layer_animation_settings.h"
 #include "ui/views/border.h"
 #include "ui/views/view_model_utils.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(USE_AURA)
 #include "ui/aura/root_window.h"
 #endif
 
 namespace {
 
@@ skipping 166 matching lines @@
   if (drag_view_ || pulsing_blocks_model_.view_size())
     return;
 
   drag_view_ = view;
 
   // When a drag and drop host is given, the item can be dragged out of the app
   // list window. In that case a proxy widget needs to be used.
   // Note: This code has very likely to be changed for Windows (non metro mode)
   // when a |drag_and_drop_host_| gets implemented.
   if (drag_and_drop_host_) {
+    // Determine the mouse offset to the center of the icon so that the drag and
+    // drop host follows this layer.
+    gfx::Vector2d delta = event.root_location() -
+                          drag_view_->GetBoundsInScreen().CenterPoint();
+    delta.set_y(delta.y() + drag_view_->title()->size().height() / 2);
     // We have to hide the original item since the drag and drop host will do
     // the OS dependent code to "lift off the dragged item".
-    // Note that we cannot use SetVisible since it would remove the mouse input.
-    drag_view_->SetSize(gfx::Size());
     drag_and_drop_host_->CreateDragIconProxy(event.root_location(),
                                              view->model()->icon(),
                                              drag_view_,
+                                             delta,
                                              kDragAndDropProxyScale);
+    HideView(drag_view_, true);
   }
   drag_start_ = event.location();
 }
 
 void AppsGridView::UpdateDrag(AppListItemView* view,
                               Pointer pointer,
                               const ui::LocatedEvent& event) {
   if (!dragging() && drag_view_ &&
       ExceededDragThreshold(event.location() - drag_start_)) {
     drag_pointer_ = pointer;
@@ skipping 15 matching lines @@
   MaybeStartPageFlipTimer(last_drag_point_);
 
   gfx::Point page_switcher_point(last_drag_point_);
   views::View::ConvertPointToTarget(this, page_switcher_view_,
                                     &page_switcher_point);
   page_switcher_view_->UpdateUIForDragPoint(page_switcher_point);
 
   if (last_drop_target != drop_target_)
     AnimateToIdealBounds();
 
-  if (drag_and_drop_host_) {
+  if (drag_and_drop_host_)
     drag_and_drop_host_->UpdateDragIconProxy(event.root_location());
-    return;
-  }
 
   drag_view_->SetPosition(
       gfx::PointAtOffsetFromOrigin(last_drag_point_ - drag_start_));
 }
 
 void AppsGridView::EndDrag(bool cancel) {
   if (forward_events_to_drag_and_drop_host_) {
     forward_events_to_drag_and_drop_host_ = false;
     drag_and_drop_host_->EndDrag(cancel);
   } else if (!cancel && dragging() && drag_view_) {
     CalculateDropTarget(last_drag_point_, true);
     if (IsValidIndex(drop_target_))
       MoveItemInModel(drag_view_, drop_target_);
   }
 
-  // In case we had a drag and drop proxy icon, we delete it and make the real
-  // item visible again.
   if (drag_and_drop_host_) {
+    // If we had a drag and drop proxy icon, we delete it and make the real
+    // item visible again.
     drag_and_drop_host_->DestroyDragIconProxy();
-    // To avoid an incorrect animation on re-group, |drag_view_| gets positioned
-    // at its last known drag location.
-    drag_view_->SetPosition(
-        gfx::PointAtOffsetFromOrigin(last_drag_point_ - drag_start_));
+    HideView(drag_view_, false);
   }
 
   drag_pointer_ = NONE;
   drop_target_ = Index();
   if (drag_view_) {
     drag_view_ = NULL;
     AnimateToIdealBounds();
   }
 
   page_flip_timer_.Stop();
@@ skipping 628 matching lines @@
   if (pagination_model_->is_valid_page(transition.target_page))
     Layout();
 }
 
 void AppsGridView::OnAppListModelStatusChanged() {
   UpdatePulsingBlockViews();
   Layout();
   SchedulePaint();
 }
 
+void AppsGridView::HideView(views::View* view, bool hide) {
+  ui::ScopedLayerAnimationSettings animator(view->layer()->GetAnimator());
+  animator.SetPreemptionStrategy(ui::LayerAnimator::IMMEDIATELY_SET_NEW_TARGET);
+  view->layer()->SetOpacity(hide ? 0 : 1);

[xiyuan, 2013/05/31 23:06:17]

This would not compile on win bots since they might not USE_AURA and thus not
having layers.

[Mr4D (OOO till 08-26), 2013/05/31 23:32:20]

Done.

+}
+
 }  // namespace app_list