Pass errors generated during limited-user registration up to the UI for display.

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * ManageProfileOverlay class
@@ skipping 33 matching lines @@
       options.ProfilesIconGrid.decorate($('manage-profile-icon-grid'));
       options.ProfilesIconGrid.decorate($('create-profile-icon-grid'));
       self.registerCommonEventHandlers_('create',
                                         self.submitCreateProfile_.bind(self));
       self.registerCommonEventHandlers_('manage',
                                         self.submitManageChanges_.bind(self));
 
       // Override the create-profile-ok handler, to avoid closing the overlay
       // until we finish creating the profile.
       $('create-profile-ok').onclick = function(event) {
+        CreateProfileOverlay.updateCreateInProgress(true);
         ManageProfileOverlay.getInstance().hideErrorBubble_('create');
-        $('create-profile-ok').disabled = true;
         self.submitCreateProfile_();
       };
 
       if (loadTimeData.getBoolean('managedUsersEnabled')) {
         $('create-profile-limited-container').hidden = false;
       }
       $('manage-profile-cancel').onclick =
           $('delete-profile-cancel').onclick =
               $('create-profile-cancel').onclick = function(event) {
         OptionsPage.closeOverlay();
@@ skipping 360 matching lines @@
       chrome.send('requestSignedInText');
       chrome.send('requestDefaultProfileIcons');
       chrome.send('requestNewProfileDefaults');
 
       $('manage-profile-overlay-create').hidden = false;
       $('manage-profile-overlay-manage').hidden = true;
       $('manage-profile-overlay-delete').hidden = true;
       $('create-profile-instructions').textContent =
          loadTimeData.getStringF('createProfileInstructions');
       this.hideErrorBubble_();
+      this.updateCreateInProgress_(false);
 
       var shortcutsEnabled = loadTimeData.getBoolean('profileShortcutsEnabled');
       $('create-shortcut-container').hidden = !shortcutsEnabled;
       $('create-shortcut').checked = shortcutsEnabled;
 
       $('create-profile-name-label').hidden = true;
       $('create-profile-name').hidden = true;
       $('create-profile-ok').disabled = true;
     },
 
     /** @override */
     showErrorBubble_: function(errorText) {
       ManageProfileOverlay.getInstance().showErrorBubble_(errorText,
                                                           'create',
                                                           false);
     },
 
     /** @override */
     hideErrorBubble_: function() {
       ManageProfileOverlay.getInstance().hideErrorBubble_('create');
     },
 
     /**
+     * Updates the UI when a profile create step begins or ends.
+     * @param {boolean} inProgress Whether the step is newly in progress, or

[James Hawkins, 2013/06/03 18:43:45]

nit: Remove comma.

[James Hawkins, 2013/06/03 18:43:45]

nit: This is confusing when reading.  Is it true when 'the step is newly in
progress || has just completed' or true when 'the step is newly in progress' and
false when  the steps 'has just completed'?

+     *     has just completed.
+     * @private
+     */
+    updateCreateInProgress_: function(inProgress) {
+      $('create-profile-ok').disabled = inProgress;
+      $('create-profile-throbber').hidden = !inProgress;
+    },
+
+    /**
      * Shows an error message describing a local error (most likely a disk
      * error) when creating a new profile. Called by BrowserOptions via the
      * BrowserOptionsHandler.
      * @private
      */
     onLocalError_: function() {
-      $('create-profile-ok').disabled = false;
+      this.updateCreateInProgress_(false);
       this.showErrorBubble_('createProfileLocalError');
     },
 
     /**
+     * Shows an error message describing a remote error (most likely a network
+     * error) when creating a new profile. Called by BrowserOptions via the
+     * BrowserOptionsHandler.
+     * @private
+     */
+    onRemoteError_: function() {
+      this.updateCreateInProgress_(false);
+      this.showErrorBubble_('createProfileRemoteError');
+    },
+
+    /**
      * For new limited users, shows a confirmation page after successfully
      * creating a new profile; otherwise, the handler will open a new window.
      * @param {Object} profileInfo An object of the form:
      *     profileInfo = {
      *       name: "Profile Name",
      *       filePath: "/path/to/profile/data/on/disk"
      *       isManaged: (true|false),
      *     };
      * @private
      */
     onSuccess_: function(profileInfo) {
+      this.updateCreateInProgress_(false);
       OptionsPage.closeOverlay();
-      $('create-profile-ok').disabled = false;
       if (profileInfo.isManaged) {
         ManagedUserCreateConfirmOverlay.setProfileInfo(profileInfo);
         OptionsPage.navigateToPage('managedUserCreateConfirm');
       }
     },
 
     /**
      * Updates the signed-in or not-signed-in UI when in create mode. Called by
      * the handler in response to the 'requestSignedInText' message.
      * @param {string} text The text to show for a signed-in user. An empty
      *     string indicates that the user is not signed in.
      * @private
      */
     updateSignedInStatus_: function(text) {
       var isSignedIn = text !== '';
       $('create-profile-limited-signed-in').hidden = !isSignedIn;
       $('create-profile-limited-not-signed-in').hidden = isSignedIn;
       $('create-profile-limited').disabled = !isSignedIn;
 
       $('create-profile-limited-signed-in-label').textContent = text;
     },
   };
 
   // Forward public APIs to private implementations.
   [
     'onLocalError',
+    'onRemoteError',
     'onSuccess',
+    'updateCreateInProgress',
     'updateSignedInStatus',
   ].forEach(function(name) {
     CreateProfileOverlay[name] = function() {
       var instance = CreateProfileOverlay.getInstance();
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay,
     CreateProfileOverlay: CreateProfileOverlay,
   };
 });