Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15774005: chromeos: Use base::MessageLoop. (Closed)

Created:
7 years, 6 months ago by xhwang
Modified:
7 years, 6 months ago
Reviewers:
DaveMoore, oshima, satorux1
CC:
chromium-reviews, yusukes+watch_chromium.org, derat+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, dkrahn+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -172 lines) Patch
M chromeos/attestation/attestation_flow_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 17 chunks +22 lines, -22 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chromeos/dbus/fake_gsm_sms_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_config_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/mock_cryptohome_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/modem_messaging_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_client_unittest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_device_client_stub.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_stub.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/shill_manager_client_stub.cc View 17 chunks +18 lines, -18 lines 0 comments Download
M chromeos/dbus/shill_profile_client_stub.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/shill_service_client_stub.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/sms_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/disks/disk_mount_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/display/output_configurator.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/ime/xkeyboard_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/login_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/memory/low_memory_listener.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chromeos/network/cert_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/geolocation_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/power/power_manager_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
PTAL
7 years, 6 months ago (2013-05-29 00:21:19 UTC) #1
xhwang
+satorux
7 years, 6 months ago (2013-05-29 17:22:56 UTC) #2
oshima
lgtm
7 years, 6 months ago (2013-05-29 21:38:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/15774005/1
7 years, 6 months ago (2013-05-29 21:40:45 UTC) #4
xhwang
7 years, 6 months ago (2013-05-29 23:04:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r202997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698