Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1577393002: Make SkBitmap::CopyTo respect requested dst color type when bitmap is texture backed. (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m48
Target Ref:
refs/heads/chrome/m48
Project:
skia
Visibility:
Public.

Description

Make SkBitmap::CopyTo respect requested dst color type when bitmap is texture backed. BUG=chromium:550559 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1576983002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/2ff162ea923f753facd606c472e6451c906d8a67

Patch Set 1 #

Patch Set 2 : Fix up test for older #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -13 lines) Patch
M include/core/SkPixelRef.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 4 chunks +15 lines, -5 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577393002/20001
4 years, 11 months ago (2016-01-12 20:13:45 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-12 20:13:45 UTC) #4
reed1
lgtm
4 years, 11 months ago (2016-01-12 20:20:45 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 20:22:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2ff162ea923f753facd606c472e6451c906d8a67

Powered by Google App Engine
This is Rietveld 408576698