Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1577373002: Add script to run gclient hooks for jiri (Closed)

Created:
4 years, 11 months ago by jamesr
Modified:
4 years, 11 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A tools/run_hooks.py View 1 chunk +34 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
jamesr
jiri is going to support running one hook per project (aka repo) so we will ...
4 years, 11 months ago (2016-01-12 22:59:50 UTC) #2
viettrungluu
lgtm w/nit https://codereview.chromium.org/1577373002/diff/1/tools/run_hooks.py File tools/run_hooks.py (right): https://codereview.chromium.org/1577373002/diff/1/tools/run_hooks.py#newcode34 tools/run_hooks.py:34: sys.exit(main(sys.argv[1:])) nit: If you're going to do ...
4 years, 11 months ago (2016-01-12 23:09:00 UTC) #3
jamesr
4 years, 11 months ago (2016-01-13 18:44:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47504e20a10980c122d1ee97891a72b651698cfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698