Issue 1577363002: Cache DirectoryBasedDartSdk sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1577363002: Cache DirectoryBasedDartSdk sources. (Closed)

Created:
4 years, 11 months ago by scheglov

Modified:
4 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cache DirectoryBasedDartSdk sources. This reduces analysis time from of a trivial Dart app from 822 ms to 762 ms. With SDK summaries. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b24cb84e8f3d83f94c4f77a04751f14bf088afab

Patch Set 1 #

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -22 lines)			Patch
	M	pkg/analyzer/lib/src/generated/sdk_io.dart	View		7 chunks	+48 lines, -22 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1577363002/diff/1/pkg/analyzer/lib/src/generated/sdk_io.dart File pkg/analyzer/lib/src/generated/sdk_io.dart (right): https://codereview.chromium.org/1577363002/diff/1/pkg/analyzer/lib/src/generated/sdk_io.dart#newcode511 pkg/analyzer/lib/src/generated/sdk_io.dart:511: print('initialLibraryMap'); Remove?

4 years, 11 months ago (2016-01-12 20:23:36 UTC) #2

scheglov

4 years, 11 months ago (2016-01-12 20:32:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b24cb84e8f3d83f94c4f77a04751f14bf088afab (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages