Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1577353002: Move BUILD.public to public.bzl. (Closed)

Created:
4 years, 11 months ago by iroth
Modified:
4 years, 11 months ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -658 lines) Patch
D BUILD.public View 1 chunk +0 lines, -505 lines 0 comments Download
A + public.bzl View 11 chunks +154 lines, -153 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
iroth
4 years, 11 months ago (2016-01-12 18:27:09 UTC) #4
dogben
lgtm
4 years, 11 months ago (2016-01-12 18:46:54 UTC) #5
mtklein
lgtm
4 years, 11 months ago (2016-01-12 19:49:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577353002/1
4 years, 11 months ago (2016-01-12 19:49:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/eeebfff54877b24151570c4f02b2299e3f9ef967
4 years, 11 months ago (2016-01-12 20:00:52 UTC) #10
iroth
4 years, 11 months ago (2016-01-12 22:19:50 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1580923002/ by iroth@google.com.

The reason for reverting is: Corresponding google-private changes not ready..

Powered by Google App Engine
This is Rietveld 408576698