Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 1577323005: Revert of content: build fix about ContentDecryptorDelegate (Closed)

Created:
4 years, 11 months ago by dshwang
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content: build fix about ContentDecryptorDelegate (patchset #1 id:1 of https://codereview.chromium.org/1575833002/ ) Reason for revert: This issue is known in crbug.com/506663 and we want to fix c++ spec and clang rather than making chromium code silly. Nico asked to revert it. Original issue's description: > content: build fix about ContentDecryptorDelegate > > clang complains it doesn't initialize const member, so this CL calls the > default constructor explicitly. > > ../../content/renderer/pepper/content_decryptor_delegate.cc:1070:32: error: default initialization of an object of const type 'const Decryptor::AudioFrames' (aka 'const list<scoped_refptr<media::AudioBuffer> >') without a user-provided default constructor > const Decryptor::AudioFrames empty_frames; > ^ > {} > ../../content/renderer/pepper/content_decryptor_delegate.cc:1282:41: error: default initialization of an object of const type 'const media::Decryptor::AudioFrames' (aka 'const list<scoped_refptr<media::AudioBuffer> >') without a user-provided default constructor > const media::Decryptor::AudioFrames empty_frames; > ^ > {} > 2 errors generated. > > Committed: https://crrev.com/c8c01a1673e799bfdc37b266acf68118cd759b08 > Cr-Commit-Position: refs/heads/master@{#368626} TBR=bbudge@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/ca370c73e46f173113531592324a4bd9210b4763 Cr-Commit-Position: refs/heads/master@{#369132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dshwang
Created Revert of content: build fix about ContentDecryptorDelegate
4 years, 11 months ago (2016-01-13 09:35:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577323005/1
4 years, 11 months ago (2016-01-13 09:36:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577323005/1
4 years, 11 months ago (2016-01-13 10:03:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577323005/1
4 years, 11 months ago (2016-01-13 10:33:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 10:55:10 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 10:56:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca370c73e46f173113531592324a4bd9210b4763
Cr-Commit-Position: refs/heads/master@{#369132}

Powered by Google App Engine
This is Rietveld 408576698