Implement (partially) ?? being compile-time constant in analyzer.

Implement (partially) ?? being compile-time constant in analyzer.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d44ed69e95bbe12822157ae3aef7f424e5a7e68

[Lasse Reichstein Nielsen, 2016-01-12 11:49:48]

lrn@google.com changed reviewers:
+ brianwilkerson@google.com

[Lasse Reichstein Nielsen, 2016-01-14 12:15:57]

lrn@google.com changed reviewers:
+ danrubel@google.com, scheglov@google.com

[Brian Wilkerson, 2016-01-14 14:55:26]

LGTM

https://codereview.chromium.org/1577293002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1577293002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:2318: if (leftOperand.isNull)
return rightOperand;
nit: As a matter of style, we always use blocks in structured statements.

[Lasse Reichstein Nielsen, 2016-01-14 15:18:09]

Description was changed from

==========
Implement (partially) ?? being compile-time constant in analyzer.
==========

to

==========
Implement (partially) ?? being compile-time constant in analyzer.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2d44ed69e95bbe12822157ae3aef7f424e5a7e68
==========

[Lasse Reichstein Nielsen, 2016-01-14 15:18:14]

Committed patchset #2 (id:20001) manually as
2d44ed69e95bbe12822157ae3aef7f424e5a7e68 (presubmit successful).

[Lasse Reichstein Nielsen, 2016-01-15 07:11:51]

https://codereview.chromium.org/1577293002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1577293002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:2318: if (leftOperand.isNull)
return rightOperand;
Consider it done.