cc/test/layer_tree_json_parser_unittest.cc - Issue 1577263004: Communicate whether passive event listeners exist to cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/layer_tree_json_parser_unittest.cc

Issue 1577263004: Communicate whether passive event listeners exist to cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners

Patch Set: Rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/test/layer_tree_json_parser.cc ('k') | cc/trees/layer_tree_host_common.cc » ('j') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/test/layer_tree_json_parser_unittest.cc

diff --git a/cc/test/layer_tree_json_parser_unittest.cc b/cc/test/layer_tree_json_parser_unittest.cc

index f1110329edd9c063800cddfc0e6da67c56795000..85e7d69ca62b2cfce91320d28f990cd7d57f9a66 100644

--- a/cc/test/layer_tree_json_parser_unittest.cc

+++ b/cc/test/layer_tree_json_parser_unittest.cc

@@ -41,8 +41,10 @@ bool LayerTreesMatch(LayerImpl* const layer_impl,

layer->scrollable()));

RETURN_IF_EXPECTATION_FAILS(EXPECT_FLOAT_EQ(layer_impl->opacity(),

layer->opacity()));

- RETURN_IF_EXPECTATION_FAILS(EXPECT_EQ(layer_impl->have_wheel_event_handlers(),

- layer->have_wheel_event_handlers()));

+ RETURN_IF_EXPECTATION_FAILS(EXPECT_EQ(layer_impl->touch_event_properties(),

+ layer->touch_event_properties()));

+ RETURN_IF_EXPECTATION_FAILS(EXPECT_EQ(layer_impl->wheel_event_properties(),

+ layer->wheel_event_properties()));

RETURN_IF_EXPECTATION_FAILS(

EXPECT_EQ(layer_impl->have_scroll_event_handlers(),

layer->have_scroll_event_handlers()));

@@ -82,7 +84,10 @@ TEST_F(LayerTreeJsonParserSanityCheck, Basic) {

parent->SetPosition(gfx::PointF(25.f, 25.f));

- child->SetHaveWheelEventHandlers(true);

+ child->SetWheelEventProperties(EventListenerProperties::kBlocking |

+ EventListenerProperties::kPassive);

+ child->SetTouchEventProperties(EventListenerProperties::kBlocking |

+ EventListenerProperties::kPassive);

child->SetHaveScrollEventHandlers(true);

parent->AddChild(std::move(child));