Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1577263004: Communicate whether passive event listeners exist to cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners
Patch Set: Fix nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index fc4425ffdfbd3e0b92986e61c7e5d703af69c9c9..d38b3b65cc1eff6e69f81e340d144b37bc84c5ce 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -175,8 +175,10 @@ HTMLInputElement::~HTMLInputElement()
// We should unregister it to avoid accessing a deleted object.
if (type() == InputTypeNames::radio)
document().formController().radioButtonGroupScope().removeButton(this);
+
+ // TODO(dtapuska): Make this passive touch listener see crbug.com/584438
if (m_hasTouchEventHandler && document().frameHost())
- document().frameHost()->eventHandlerRegistry().didRemoveEventHandler(*this, EventHandlerRegistry::TouchEvent);
+ document().frameHost()->eventHandlerRegistry().didRemoveEventHandler(*this, EventHandlerRegistry::TouchEventBlocking);
#endif
}
@@ -419,10 +421,11 @@ void HTMLInputElement::updateTouchEventHandlerRegistry()
// If the Document is being or has been stopped, don't register any handlers.
if (document().frameHost() && document().lifecycle().state() < DocumentLifecycle::Stopping) {
EventHandlerRegistry& registry = document().frameHost()->eventHandlerRegistry();
+ // TODO(dtapuska): Make this passive touch listener see crbug.com/584438
if (hasTouchEventHandler)
- registry.didAddEventHandler(*this, EventHandlerRegistry::TouchEvent);
+ registry.didAddEventHandler(*this, EventHandlerRegistry::TouchEventBlocking);
else
- registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchEvent);
+ registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchEventBlocking);
m_hasTouchEventHandler = hasTouchEventHandler;
}
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698