third_party/WebKit/Source/core/dom/Node.cpp - Issue 1577263004: Communicate whether passive event listeners exist to cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 1577263004: Communicate whether passive event listeners exist to cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners

Patch Set: Fix nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/web_layer_tree_view_impl_for_testing.cc ('k') | third_party/WebKit/Source/core/frame/EventHandlerRegistry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 89d93e27a4d7a683966ad0258792e67e9d3c0e92..1bbe752ef37c9cb6d08a11745526802aa4fbc092 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -1823,7 +1823,7 @@ bool Node::addEventListenerInternal(const AtomicString& eventType, PassRefPtrWil

document().addListenerTypeIfNeeded(eventType);

if (FrameHost* frameHost = document().frameHost())

- frameHost->eventHandlerRegistry().didAddEventHandler(*this, eventType);

+ frameHost->eventHandlerRegistry().didAddEventHandler(*this, eventType, options);

return true;

}

@@ -1836,7 +1836,7 @@ bool Node::removeEventListenerInternal(const AtomicString& eventType, PassRefPtr

// FIXME: Notify Document that the listener has vanished. We need to keep track of a number of

// listeners for each type, not just a bool - see https://bugs.webkit.org/show_bug.cgi?id=33861

if (FrameHost* frameHost = document().frameHost())

- frameHost->eventHandlerRegistry().didRemoveEventHandler(*this, eventType);

+ frameHost->eventHandlerRegistry().didRemoveEventHandler(*this, eventType, options);

return true;

}