Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1577223002: Add @@species/better subclassing support to Promises (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add @@species/better subclassing support to Promises This patch makes Promise.prototype.then use @@species as specified in ES2015. The fix is hoped for by certain users, such as legacy core.js versions which encounter an unhandled Promise reject (complete with an ugly console message) when Promise subclassing is supported in a mostly correct way, and we do error checking on Promise constructors, but @@species is not supported. BUG=chromium:575314, v8:4633 LOG=Y R=adamk Committed: https://crrev.com/569145019d8af8330a4702ace5bd93a9e51077f2 Cr-Commit-Position: refs/heads/master@{#33225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M src/js/promise.js View 2 chunks +3 lines, -1 line 0 comments Download
A test/mjsunit/harmony/promise-species.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
PTAL. This patch depends on https://codereview.chromium.org/1574903004
4 years, 11 months ago (2016-01-12 01:59:34 UTC) #1
adamk
lgtm
4 years, 11 months ago (2016-01-12 02:18:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577223002/1
4 years, 11 months ago (2016-01-12 06:09:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 06:33:00 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 06:33:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/569145019d8af8330a4702ace5bd93a9e51077f2
Cr-Commit-Position: refs/heads/master@{#33225}

Powered by Google App Engine
This is Rietveld 408576698