Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3827)

Unified Diff: chrome/test/chromedriver/chrome/devtools_event_listener.h

Issue 15772009: [chromedriver] Fix race where we might not wait for page load after navigating. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_event_listener.h
diff --git a/chrome/test/chromedriver/chrome/devtools_event_listener.h b/chrome/test/chromedriver/chrome/devtools_event_listener.h
index 6ce0385bb5a9f5cf33af56fee631c2f49aeb1855..610b7f4932c9cedfebe1fb3a93bc68da316a8657 100644
--- a/chrome/test/chromedriver/chrome/devtools_event_listener.h
+++ b/chrome/test/chromedriver/chrome/devtools_event_listener.h
@@ -14,16 +14,23 @@ class DictionaryValue;
class DevToolsClient;
class Status;
-// Listens to WebKit Inspector events and DevTools debugger connection.
+// Receives notification of incoming Blink Inspector messages and connection
+// to the DevTools server.
class DevToolsEventListener {
public:
- virtual ~DevToolsEventListener() {}
+ virtual ~DevToolsEventListener();
- virtual Status OnConnected(DevToolsClient* client) = 0;
+ // Called when a connection is made to the DevTools server.
+ virtual Status OnConnected(DevToolsClient* client);
+ // Called when an event is received.
virtual void OnEvent(DevToolsClient* client,
const std::string& method,
- const base::DictionaryValue& params) = 0;
+ const base::DictionaryValue& params);
+
+ // Called when a command success response is received.
+ virtual Status OnCommandSuccess(DevToolsClient* client,
+ const std::string& method);
};
#endif // CHROME_TEST_CHROMEDRIVER_CHROME_DEVTOOLS_EVENT_LISTENER_H_

Powered by Google App Engine
This is Rietveld 408576698