Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2292)

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.h

Issue 15772009: [chromedriver] Fix race where we might not wait for page load after navigating. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/devtools_client_impl.h
diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.h b/chrome/test/chromedriver/chrome/devtools_client_impl.h
index f46d6b2aeca850a9b4b622f6ff995d651e8e28b0..e30410ba0607e92d69f1a0ba823c39b59ce6f0e3 100644
--- a/chrome/test/chromedriver/chrome/devtools_client_impl.h
+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.h
@@ -103,10 +103,11 @@ class DevToolsClientImpl : public DevToolsClient {
kReceived
};
struct ResponseInfo {
- ResponseInfo();
+ explicit ResponseInfo(const std::string& method);
~ResponseInfo();
ResponseState state;
+ std::string method;
internal::InspectorCommandResponse response;
};
typedef std::map<int, linked_ptr<ResponseInfo> > ResponseInfoMap;
@@ -121,6 +122,7 @@ class DevToolsClientImpl : public DevToolsClient {
const internal::InspectorCommandResponse& response);
Status EnsureListenersNotifiedOfConnect();
Status EnsureListenersNotifiedOfEvent();
+ Status EnsureListenersNotifiedOfCommandResponse();
scoped_ptr<SyncWebSocket> socket_;
GURL url_;
@@ -132,6 +134,8 @@ class DevToolsClientImpl : public DevToolsClient {
std::list<DevToolsEventListener*> unnotified_connect_listeners_;
std::list<DevToolsEventListener*> unnotified_event_listeners_;
const internal::InspectorEvent* unnotified_event_;
+ std::list<DevToolsEventListener*> unnotified_cmd_response_listeners_;
+ linked_ptr<ResponseInfo> unnotified_cmd_response_info_;
ResponseInfoMap response_info_map_;
int next_id_;
int stack_count_;
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698