Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: runtime/bin/io_buffer.cc

Issue 15772005: - Add different types for persistent and weak persistent handles (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | runtime/bin/isolate_data.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/io_buffer.h" 5 #include "bin/io_buffer.h"
6 6
7 7
8 namespace dart { 8 namespace dart {
9 namespace bin { 9 namespace bin {
10 10
11 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) { 11 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) {
12 uint8_t* data = Allocate(size); 12 uint8_t* data = Allocate(size);
13 Dart_Handle result = Dart_NewExternalTypedData(kUint8, 13 Dart_Handle result = Dart_NewExternalTypedData(kUint8, data, size);
14 data, size, 14 Dart_NewWeakPersistentHandle(result, data, IOBuffer::Finalizer);
15 data, IOBuffer::Finalizer); 15
16 if (Dart_IsError(result)) { 16 if (Dart_IsError(result)) {
17 Free(data); 17 Free(data);
18 Dart_PropagateError(result); 18 Dart_PropagateError(result);
19 } 19 }
20 if (buffer != NULL) { 20 if (buffer != NULL) {
21 *buffer = data; 21 *buffer = data;
22 } 22 }
23 return result; 23 return result;
24 } 24 }
25 25
26 uint8_t* IOBuffer::Allocate(intptr_t size) { 26 uint8_t* IOBuffer::Allocate(intptr_t size) {
27 return new uint8_t[size]; 27 return new uint8_t[size];
28 } 28 }
29 29
30 } // namespace bin 30 } // namespace bin
31 } // namespace dart 31 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | runtime/bin/isolate_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698