Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1577163003: Add deepPath (Closed)

Created:
4 years, 11 months ago by yuzusan
Modified:
4 years, 11 months ago
Reviewers:
yuzuchan, hayato, kojii, kochi
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EventPath available as Event.deepPath as well. Spec is the link below. http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath This feature is guarded by ShadowDOMV1 RuntimeEnabled flag. BUG=531990 Committed: https://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf Cr-Commit-Position: refs/heads/master@{#370652}

Patch Set 1 #

Patch Set 2 : Add deepPath #

Patch Set 3 : Resolve a merge conflict #

Patch Set 4 : Fix layout test results #

Total comments: 8

Patch Set 5 : Fix layout tests #

Patch Set 6 : Fetched latest changes #

Patch Set 7 : Change Layout test results #

Patch Set 8 : Modify UseCounter #

Patch Set 9 : Resolve Patch Failure #

Patch Set 10 : Add deepPath layout test #

Total comments: 1

Patch Set 11 : Remove unnecessary line #

Patch Set 12 : Modify UseCounter #

Patch Set 13 : Change layout test results #

Messages

Total messages: 22 (10 generated)
kochi
You will also have to change the following couple of files: webexposed/global-interface-listing-shared-worker.html webexposed/global-interface-listing.html https://codereview.chromium.org/1577163003/diff/60001/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt File ...
4 years, 11 months ago (2016-01-13 09:03:28 UTC) #4
yuzuchan
Thank you for the review. https://codereview.chromium.org/1577163003/diff/60001/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt File third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt (left): https://codereview.chromium.org/1577163003/diff/60001/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt#oldcode461 third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt:461: setter width On 2016/01/13 ...
4 years, 11 months ago (2016-01-15 04:18:31 UTC) #7
kochi
lgtm
4 years, 11 months ago (2016-01-18 08:41:30 UTC) #8
hayato
lgtm I guess the description could be improved. Let's chat offline tomorrow. :)
4 years, 11 months ago (2016-01-18 09:25:50 UTC) #9
kochi
btw, this adds a web exposed API (even behind ShadowDOMV1 flag), LayoutTests/webexposed/* should fail without ...
4 years, 11 months ago (2016-01-19 04:09:09 UTC) #11
kochi
https://codereview.chromium.org/1577163003/diff/180001/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1577163003/diff/180001/third_party/WebKit/Source/core/frame/UseCounter.h#newcode975 third_party/WebKit/Source/core/frame/UseCounter.h:975: Added an extra newline?
4 years, 11 months ago (2016-01-19 05:52:19 UTC) #12
kochi
On 2016/01/19 04:09:09, kochi wrote: > btw, this adds a web exposed API (even behind ...
4 years, 11 months ago (2016-01-19 06:00:55 UTC) #13
hayato
Yuzu, FYI. I've just changed Event.deepPath from a property to a method: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c Do not ...
4 years, 11 months ago (2016-01-21 05:53:11 UTC) #14
yuzuchan
On 2016/01/21 05:53:11, hayato wrote: > Yuzu, FYI. > > I've just changed Event.deepPath from ...
4 years, 11 months ago (2016-01-21 07:44:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163003/240001
4 years, 11 months ago (2016-01-21 07:45:06 UTC) #18
commit-bot: I haz the power
Committed patchset #13 (id:240001)
4 years, 11 months ago (2016-01-21 08:52:42 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 08:53:45 UTC) #22
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf
Cr-Commit-Position: refs/heads/master@{#370652}

Powered by Google App Engine
This is Rietveld 408576698