Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1577153002:
DevTools: do not use ScriptFunctionCall in the front-end embedder. (Closed)
|
Created:
4 years, 11 months ago by pfeldman Modified:
4 years, 11 months ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: do not use ScriptFunctionCall in the front-end embedder.
NOTRY=true
Committed: https://crrev.com/7dc9e3a5229e69d823bf6cf76dd4943de5e8b9c8
Cr-Commit-Position: refs/heads/master@{#371677}
Patch Set 1 #Patch Set 2 : recursion scope added #
Messages
Total messages: 22 (11 generated)
forgot to send it out long ago
pfeldman@chromium.org changed reviewers: + dgozman@chromium.org
lgtm
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577153002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. ========== to ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. Committed: https://crrev.com/4a595ca1ace2d1592d154cac89b1085f7baa771b Cr-Commit-Position: refs/heads/master@{#371337} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4a595ca1ace2d1592d154cac89b1085f7baa771b Cr-Commit-Position: refs/heads/master@{#371337}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1635883004/ by caseq@chromium.org. The reason for reverting is: Breaks context menu handling in DevTools front-end..
Message was sent while issue was closed.
Description was changed from ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. Committed: https://crrev.com/4a595ca1ace2d1592d154cac89b1085f7baa771b Cr-Commit-Position: refs/heads/master@{#371337} ========== to ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. Committed: https://crrev.com/4a595ca1ace2d1592d154cac89b1085f7baa771b Cr-Commit-Position: refs/heads/master@{#371337} ==========
The CQ bit was checked by pfeldman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/1577153002/#ps20001 (title: "recursion scope added")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577153002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. Committed: https://crrev.com/4a595ca1ace2d1592d154cac89b1085f7baa771b Cr-Commit-Position: refs/heads/master@{#371337} ========== to ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. NOTRY=true ==========
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577153002/20001
Message was sent while issue was closed.
Description was changed from ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. NOTRY=true ========== to ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. NOTRY=true ========== to ========== DevTools: do not use ScriptFunctionCall in the front-end embedder. NOTRY=true Committed: https://crrev.com/7dc9e3a5229e69d823bf6cf76dd4943de5e8b9c8 Cr-Commit-Position: refs/heads/master@{#371677} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7dc9e3a5229e69d823bf6cf76dd4943de5e8b9c8 Cr-Commit-Position: refs/heads/master@{#371677} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
