Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1577143002: associate a staticInvokeType with loadLibrary (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

associate a staticInvokeType with loadLibrary I missed this early-exit code path. This was caught by DDC's tests. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/5947a2047f94e9819ab6ab0446af1e41bb6dd7b6

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
@Leaf -- this was the bug with DDC after my changes. Otherwise it all seems ...
4 years, 11 months ago (2016-01-11 22:37:26 UTC) #2
Leaf
lgtm
4 years, 11 months ago (2016-01-13 01:09:59 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-13 18:40:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5947a2047f94e9819ab6ab0446af1e41bb6dd7b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698