Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2957)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 157713002: Switch DomAutomationController to be a RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nasko@ CR feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 1b13f681a40d1b5b380e9f7a470883728c9dc230..2c3511cdf76db83531d470a708c85f9a07261240 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -23,6 +23,7 @@
#include "content/common/socket_stream_handle_data.h"
#include "content/common/swapped_out_messages.h"
#include "content/common/view_messages.h"
+#include "content/public/common/bindings_policy.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/context_menu_params.h"
@@ -39,6 +40,7 @@
#include "content/renderer/browser_plugin/browser_plugin_manager.h"
#include "content/renderer/child_frame_compositing_helper.h"
#include "content/renderer/context_menu_params_builder.h"
+#include "content/renderer/dom_automation_controller.h"
#include "content/renderer/internal_document_state_data.h"
#include "content/renderer/npapi/plugin_channel_host.h"
#include "content/renderer/render_thread_impl.h"
@@ -1187,7 +1189,16 @@ void RenderFrameImpl::didClearWindowObject(blink::WebFrame* frame,
// * enabled_bindings_
// * dom_automation_controller_
// * stats_collection_controller_
+
render_view_->didClearWindowObject(frame, world_id);
+
+ // Only install controllers into the main world.
+ if (world_id)
+ return;
+
+ if (render_view_->GetEnabledBindings() & BINDINGS_POLICY_DOM_AUTOMATION) {
Charlie Reis 2014/02/15 01:47:33 nit: No braces.
mkosiba (inactive) 2014/02/17 17:42:31 Done.
+ DomAutomationController::Install(this, frame);
+ }
}
void RenderFrameImpl::didCreateDocumentElement(blink::WebFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698