Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 157713002: Switch DomAutomationController to be a RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add notification to interstitialpageimpl Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 6106e97b4bf119eafca78434c351a2392c022783..dfc7540d4ae8585685f7717e56f5b6a822991190 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -22,6 +22,7 @@
#include "content/common/socket_stream_handle_data.h"
#include "content/common/swapped_out_messages.h"
#include "content/common/view_messages.h"
+#include "content/public/common/bindings_policy.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/context_menu_params.h"
@@ -37,6 +38,7 @@
#include "content/renderer/browser_plugin/browser_plugin_manager.h"
#include "content/renderer/child_frame_compositing_helper.h"
#include "content/renderer/context_menu_params_builder.h"
+#include "content/renderer/dom_automation_controller.h"
#include "content/renderer/internal_document_state_data.h"
#include "content/renderer/npapi/plugin_channel_host.h"
#include "content/renderer/render_thread_impl.h"
@@ -1079,6 +1081,14 @@ void RenderFrameImpl::didClearWindowObject(blink::WebFrame* frame,
// * enabled_bindings_
// * dom_automation_controller_
// * stats_collection_controller_
+
+ if (!world_id) {
nasko 2014/02/11 17:32:33 nit: Why not keep the pattern from the RV version
+ // Only install controllers into the main world.
+ if (render_view_->GetEnabledBindings() & BINDINGS_POLICY_DOM_AUTOMATION) {
+ DomAutomationController::Install(this, frame);
+ }
+ }
+
render_view_->didClearWindowObject(frame, world_id);
}

Powered by Google App Engine
This is Rietveld 408576698