Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 1577093002: Remove gcc_version from gyp and gn files. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, blink-reviews, groby+spellwatch_chromium.org, cc-bugs_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gcc_version from gyp and gn files. We used this to check if gcc is newer than 4.8 which is now required. Remove the plumbing for this until we need to check gcc compiler versions again, if ever. No behavior change. BUG=573778 Committed: https://crrev.com/b6f01608b03226f4b638894797193420c16f1f87 Cr-Commit-Position: refs/heads/master@{#368706}

Patch Set 1 #

Patch Set 2 : moar #

Total comments: 1

Patch Set 3 : format #

Patch Set 4 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -130 lines) Patch
M build/common.gypi View 8 chunks +8 lines, -44 lines 0 comments Download
M build/compiler_version.py View 1 2 chunks +2 lines, -17 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 4 chunks +15 lines, -24 lines 0 comments Download
D build/config/gcc/gcc_version.gni View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/hunspell/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/hunspell/hunspell.gyp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
https://codereview.chromium.org/1577093002/diff/20001/build/compiler_version.py File build/compiler_version.py (right): https://codereview.chromium.org/1577093002/diff/20001/build/compiler_version.py#newcode35 build/compiler_version.py:35: if tool not in ('assembler',): There's one call to ...
4 years, 11 months ago (2016-01-11 21:05:54 UTC) #3
brettw
lgtm
4 years, 11 months ago (2016-01-11 22:24:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577093002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577093002/60001
4 years, 11 months ago (2016-01-11 22:25:27 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-11 23:11:14 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 23:13:09 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b6f01608b03226f4b638894797193420c16f1f87
Cr-Commit-Position: refs/heads/master@{#368706}

Powered by Google App Engine
This is Rietveld 408576698