Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

Issue 1577073005: Add <link rel=preload> onload support for scripts and styles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed lifetime issue of LinkPreloadResourceClients Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h
diff --git a/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h b/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9935d3c72b5277514d059e61bfba10f124032cb
--- /dev/null
+++ b/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h
@@ -0,0 +1,114 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef LinkPreloadResourceClients_h
+#define LinkPreloadResourceClients_h
+
+#include "core/fetch/FontResource.h"
+#include "core/fetch/ImageResourceClient.h"
+#include "core/fetch/ResourceOwner.h"
+#include "core/fetch/ScriptResource.h"
+#include "core/fetch/StyleSheetResourceClient.h"
+
+namespace blink {
+
+class LinkLoader;
+
+class LinkPreloadResourceClient : public NoBaseWillBeGarbageCollectedFinalized<LinkPreloadResourceClient> {
+public:
+ virtual ~LinkPreloadResourceClient() { }
+
+ void triggerEvents(Resource*);
+ virtual void callSetResource(Resource*) = 0;
Nate Chapin 2016/01/13 23:52:24 Maybe take the Resource* as a parameter in the var
Yoav Weiss 2016/01/14 10:10:02 good call! :)
+
+protected:
+ LinkPreloadResourceClient(LinkLoader*);
+private:
+ WeakPtr<LinkLoader> m_loader;
Nate Chapin 2016/01/13 23:52:23 LinkLoader owns LinkPreloadResourceClient. Wouldn'
Yoav Weiss 2016/01/14 10:10:02 true. Previousely left the weakPtr around since th
+};
+
+class LinkPreloadScriptResourceClient: public ResourceOwner<Resource, ScriptResourceClient>, public LinkPreloadResourceClient {
Nate Chapin 2016/01/13 23:52:23 Here and below: If I understand oilpan correctly,
Yoav Weiss 2016/01/14 10:10:02 ok
+public:
+ static PassOwnPtr<LinkPreloadScriptResourceClient> create(LinkLoader* loader)
+ {
+ return adoptPtr(new LinkPreloadScriptResourceClient(loader));
+ }
+
+ ~LinkPreloadScriptResourceClient() override { clearResource(); }
+
+ virtual String debugName() const { return "LinkPreloadScript"; }
+
+ void notifyFinished(Resource* resource) override
+ {
+ triggerEvents(resource);
+ clearResource();
Nate Chapin 2016/01/13 23:52:24 Why does notifyFinished() call clearResource() in
Yoav Weiss 2016/01/14 10:10:02 leftover. Apologies.
+ }
+
+ void callSetResource(Resource* resource)
+ {
+ setResource(resource);
+ }
+
+private:
+ LinkPreloadScriptResourceClient(LinkLoader* loader)
+ : LinkPreloadResourceClient(loader)
+ {
+ }
+};
+
+class LinkPreloadStyleResourceClient: public ResourceOwner<Resource, StyleSheetResourceClient>, public LinkPreloadResourceClient {
+public:
+ static PassOwnPtr<LinkPreloadStyleResourceClient> create(LinkLoader* loader)
+ {
+ return adoptPtr(new LinkPreloadStyleResourceClient(loader));
+ }
+
+ virtual String debugName() const { return "LinkPreloadStyle"; }
+
+ void notifyFinished(Resource* resource) override
+ {
+ triggerEvents(resource);
+ }
+
+ void callSetResource(Resource* resource)
+ {
+ setResource(resource);
+ }
+
+private:
+ LinkPreloadStyleResourceClient(LinkLoader* loader)
+ : LinkPreloadResourceClient(loader)
+ {
+ }
+};
+
+class LinkPreloadImageResourceClient: public ResourceOwner<Resource, ImageResourceClient>, public LinkPreloadResourceClient {
+public:
+ static PassOwnPtr<LinkPreloadImageResourceClient> create(LinkLoader* loader)
+ {
+ return adoptPtr(new LinkPreloadImageResourceClient(loader));
+ }
+
+ virtual String debugName() const { return "LinkPreloadImage"; }
+
+ void notifyFinished(Resource* resource) override
+ {
+ triggerEvents(resource);
+ }
+
+ void callSetResource(Resource* resource)
+ {
+ setResource(resource);
+ }
+
+private:
+ LinkPreloadImageResourceClient(LinkLoader* loader)
+ : LinkPreloadResourceClient(loader)
+ {
+ }
+};
+
+}
+
+#endif // LinkPreloadResourceClients_h

Powered by Google App Engine
This is Rietveld 408576698