Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1577073002: remove external header for SkModeColorFilter (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : duh -- actually move the header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -254 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/effects/SkModeColorFilter.h View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + src/core/SkModeColorFilter.h View 1 2 3 chunks +7 lines, -12 lines 0 comments Download
A + src/core/SkModeColorFilter.cpp View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
D src/effects/SkColorFilters.cpp View 1 1 chunk +0 lines, -170 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
reed1
4 years, 11 months ago (2016-01-11 20:41:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577073002/40001
4 years, 11 months ago (2016-01-11 20:54:57 UTC) #6
reed1
afaik, there are no refs to the header in chrome or android
4 years, 11 months ago (2016-01-11 21:01:15 UTC) #7
f(malita)
lgtm
4 years, 11 months ago (2016-01-11 21:06:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 21:07:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577073002/40001
4 years, 11 months ago (2016-01-11 21:08:23 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:09:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c7141eb8fba41f1e098499ef17d0bc79641d54c5

Powered by Google App Engine
This is Rietveld 408576698