Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1577043002:
Support @@species in Array.prototype.concat (Closed)
|
Created:
4 years, 11 months ago by Dan Ehrenberg Modified:
4 years, 10 months ago Reviewers:
Camillo Bruni CC:
adamk, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionSupport @@species in Array.prototype.concat
This patch makes Array.prototype.concat support subclassing Arrays
and constructing instances properly with Symbol.species. It is
guarded by the --harmony-species flag.
R=cbruni
LOG=Y
BUG=v8:4093
Committed: https://crrev.com/22be78430ad1530a012b1d7bfe13d4518e246267
Cr-Commit-Position: refs/heads/master@{#33503}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Improvements from cbruni's review #Patch Set 3 : Fix exceptions thrown from exceeding array length #
Messages
Total messages: 22 (10 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with nits. Sorry, I didn't see your CL earlier. https://codereview.chromium.org/1577043002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1577043002/diff/1/src/builtins.cc#newcode656 src/builtins.cc:656: return true; I think you can return directly false here (probably doesn't change much). https://codereview.chromium.org/1577043002/diff/1/src/builtins.cc#newcode1395 src/builtins.cc:1395: } else if (array_species) { ah you got me confused with array_species, could you rename it to is_array_species?
https://codereview.chromium.org/1577043002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1577043002/diff/1/src/builtins.cc#newcode656 src/builtins.cc:656: return true; On 2016/01/15 at 14:17:27, cbruni wrote: > I think you can return directly false here (probably doesn't change much). Oh right, done. https://codereview.chromium.org/1577043002/diff/1/src/builtins.cc#newcode1395 src/builtins.cc:1395: } else if (array_species) { On 2016/01/15 at 14:17:27, cbruni wrote: > ah you got me confused with array_species, could you rename it to is_array_species? Good idea, done
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org Link to the patchset: https://codereview.chromium.org/1577043002/#ps20001 (title: "Improvements from cbruni's review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577043002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14178)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577043002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org Link to the patchset: https://codereview.chromium.org/1577043002/#ps40001 (title: "Fix exceptions thrown from exceeding array length")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577043002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Support @@species in Array.prototype.concat This patch makes Array.prototype.concat support subclassing Arrays and constructing instances properly with Symbol.species. It is guarded by the --harmony-species flag. R=cbruni LOG=Y BUG=v8:4093 ========== to ========== Support @@species in Array.prototype.concat This patch makes Array.prototype.concat support subclassing Arrays and constructing instances properly with Symbol.species. It is guarded by the --harmony-species flag. R=cbruni LOG=Y BUG=v8:4093 Committed: https://crrev.com/22be78430ad1530a012b1d7bfe13d4518e246267 Cr-Commit-Position: refs/heads/master@{#33503} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/22be78430ad1530a012b1d7bfe13d4518e246267 Cr-Commit-Position: refs/heads/master@{#33503} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
