third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html - Issue 1576993003: [css-grid] Fix placement for unknown named grid lines

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html

Issue 1576993003: [css-grid] Fix placement for unknown named grid lines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing last review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <link href="resources/grid.css" rel="stylesheet">	3 <link href="resources/grid.css" rel="stylesheet">

4 <style>	4 <style>

5 .grid {	5 .grid {

6 grid-template-rows: 10px 20px;	6 grid-template-rows: 10px 20px;

	7 grid-auto-rows: 5px;

7 grid-template-columns: 30px 40px;	8 grid-template-columns: 30px 40px;

	9 grid-auto-columns: 15px;

8 grid-auto-flow: row;	10 grid-auto-flow: row;

9 }	11 }

10	12

11 .bothNamedGridLineRow {	13 .bothNamedGridLineRow {

12 grid-row: nonExistentArea / nonExistentArea;	14 grid-row: nonExistentArea / nonExistentArea;

13 grid-column: 1;	15 grid-column: 1;

	16 background-color: lime;

14 }	17 }

15	18

16 .bothNamedGridLineColumn {	19 .bothNamedGridLineColumn {

17 grid-row: 1;	20 grid-row: 1;

18 grid-column: nonExistentArea / span 3;	21 grid-column: nonExistentArea / span 3;

	22 background-color: lime;

19 }	23 }

20	24

21 .namedGridLineSpanRow {	25 .namedGridLineSpanRow {

22 grid-row: nonExistentArea / span 5 firstRow;	26 grid-row: nonExistentArea / span 5 firstRow;

23 grid-column: 1;	27 grid-column: 1;

	28 background-color: lime;

24 }	29 }

25	30

26 .namedGridLineSpanColumn {	31 .namedGridLineSpanColumn {

27 grid-row: 1;	32 grid-row: 1;

28 grid-column: nonExistentArea / span;	33 grid-column: nonExistentArea / span;

	34 background-color: lime;

29 }	35 }

30 </style>	36 </style>

31 <script src="../../resources/check-layout.js"></script>	37 <script src="../../resources/check-layout.js"></script>

32 <body onload="checkLayout('.grid')">	38 <body onload="checkLayout('.grid')">

33	39

34 <p>This test checks that unknown named area are treated as 'auto' by applying th e auto-placement algorithm when mandated.</p>	40 <p>This test checks that unknown named area are are resolved properly considerin g all the implicit grid lines to have the given names.</p>

35	41

36 <div style="position: relative">	42 <div style="position: relative">

37 <div class="grid">	43 <div class="grid">

38 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>	44 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>

39 <div class="sizedToGridArea bothNamedGridLineRow" data-offset-x="0" data -offset-y="10" data-expected-width="30" data-expected-height="20"></div>	45 <div class="sizedToGridArea bothNamedGridLineRow" data-offset-x="0" data -offset-y="35" data-expected-width="30" data-expected-height="5"></div>

40 </div>	46 </div>

41 </div>	47 </div>

42	48

43 <div style="position: relative">	49 <div style="position: relative">

44 <div class="grid">	50 <div class="grid">

45 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>	51 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>

46 <div class="sizedToGridArea bothNamedGridLineColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="10"></div>	52 <div class="sizedToGridArea bothNamedGridLineColumn" data-offset-x="85" data-offset-y="0" data-expected-width="45" data-expected-height="10"></div>

47 </div>	53 </div>

48 </div>	54 </div>

49	55

50 <div style="position: relative">	56 <div style="position: relative">

51 <div class="grid">	57 <div class="grid">

52 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>	58 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>

53 <div class="sizedToGridArea namedGridLineSpanRow" data-offset-x="0" data -offset-y="10" data-expected-width="30" data-expected-height="20"></div>	59 <div class="sizedToGridArea namedGridLineSpanRow" data-offset-x="0" data -offset-y="35" data-expected-width="30" data-expected-height="25"></div>

54 </div>	60 </div>

55 </div>	61 </div>

56	62

57 <div style="position: relative">	63 <div style="position: relative">

58 <div class="grid">	64 <div class="grid">

59 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>	65 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>

60 <div class="sizedToGridArea namedGridLineSpanColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="10"></div>	66 <div class="sizedToGridArea namedGridLineSpanColumn" data-offset-x="85" data-offset-y="0" data-expected-width="15" data-expected-height="10"></div>

61 </div>	67 </div>

62 </div>	68 </div>

63	69

64 </body>	70 </body>

65 </html>	71 </html>

OLD	NEW