src/core/SkBitmap.cpp - Issue 1576983002: Make SkBitmap::CopyTo respect requested dst color type when bitmap is texture backed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmap.cpp

Issue 1576983002: Make SkBitmap::CopyTo respect requested dst color type when bitmap is texture backed. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix size_t warnings Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkBitmap.cpp

diff --git a/src/core/SkBitmap.cpp b/src/core/SkBitmap.cpp

index c66a5b2fd5c2495e05386fe3c6d81568c4d87adc..bdf1daafccc25434f6286df55223c5475f665ddd 100644

--- a/src/core/SkBitmap.cpp

+++ b/src/core/SkBitmap.cpp

@@ -828,7 +828,7 @@ bool SkBitmap::copyTo(SkBitmap* dst, SkColorType dstColorType, Allocator* alloc)

SkIRect subset;

subset.setXYWH(fPixelRefOrigin.fX, fPixelRefOrigin.fY,

fInfo.width(), fInfo.height());

- if (fPixelRef->readPixels(&tmpSrc, &subset)) {

+ if (fPixelRef->readPixels(&tmpSrc, dstColorType, &subset)) {

if (fPixelRef->info().alphaType() == kUnpremul_SkAlphaType) {

// FIXME: The only meaningful implementation of readPixels

// (GrPixelRef) assumes premultiplied pixels.

« no previous file with comments | « include/gpu/SkGrPixelRef.h ('k') | src/core/SkBitmapDevice.cpp » ('j') | no next file with comments »