Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1576983002: Make SkBitmap::CopyTo respect requested dst color type when bitmap is texture backed. (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix size_t warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -13 lines) Patch
M include/core/SkPixelRef.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 4 chunks +15 lines, -5 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
bsalomon
Fixes the video rendered to PDF color swap issue.
4 years, 11 months ago (2016-01-11 16:19:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576983002/1
4 years, 11 months ago (2016-01-11 16:21:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/5229)
4 years, 11 months ago (2016-01-11 16:22:14 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576983002/20001
4 years, 11 months ago (2016-01-11 16:24:11 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 16:44:40 UTC) #11
reed1
lgtm
4 years, 11 months ago (2016-01-11 19:06:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576983002/20001
4 years, 11 months ago (2016-01-11 19:09:13 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:14:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9d22fd6e7bd1e93bb192f4de649b6b170c9d261a

Powered by Google App Engine
This is Rietveld 408576698