components/autofill/content/renderer/form_autofill_util.cc - Issue 15769018: [Autofill] Determine Popup RTLness from page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responding to comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/form_autofill_util.cc

diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc

index 40a20e14476fcb9a4f656e2dd79678fa25c0081f..8ff816c1dbc4a8e27c719e9380a1caae1ca1c00b 100644

--- a/components/autofill/content/renderer/form_autofill_util.cc

+++ b/components/autofill/content/renderer/form_autofill_util.cc

@@ -714,9 +714,11 @@ void WebFormControlElementToFormField(const WebFormControlElement& element,

field->is_autofilled = input_element->isAutofilled();

field->is_focusable = input_element->isFocusable();

- field->should_autocomplete = input_element->autoComplete();

field->is_checkable = IsCheckableElement(input_element);

field->is_checked = input_element->isChecked();

+ field->should_autocomplete = input_element->autoComplete();

+ field->text_direction = input_element->directionForFormData() == "rtl" ?

+ base::i18n::RIGHT_TO_LEFT : base::i18n::LEFT_TO_RIGHT;

} else if (extract_mask & EXTRACT_OPTIONS) {

// Set option strings on the field if available.

DCHECK(IsSelectElement(element));