chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc - Issue 15769018: [Autofill] Determine Popup RTLness from page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responding to comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

diff --git a/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc b/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

index ad18befaa0bd848896a8ff4978065f2f48270a8d..6d788dcbb72f9822ac199241df32571df280c40f 100644

--- a/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

+++ b/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

@@ -6,7 +6,6 @@

#include <gdk/gdkkeysyms.h>

-#include "base/i18n/rtl.h"

#include "base/logging.h"

#include "base/utf_string_conversions.h"

#include "chrome/browser/ui/autofill/autofill_popup_controller.h"

@@ -237,7 +236,7 @@ void AutofillPopupViewGtk::DrawAutofillEntry(cairo_t* cairo_context,

entry_rect.y() +

(row_height - controller_->GetNameFontForRow(index).GetHeight()) / 2);

- bool is_rtl = base::i18n::IsRTL();

+ bool is_rtl = controller_->IsRTL();

int value_content_x = is_rtl ?

entry_rect.width() - value_text_width - kEndPadding : kEndPadding;