chrome/browser/ui/views/autofill/autofill_popup_view_views.cc - Issue 15769018: [Autofill] Determine Popup RTLness from page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responding to comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

diff --git a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc b/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

index bdc8e32d7ee95c37641d4cdb30c55741f1505b93..459857387ba87d6c0608c0a0342322e6718121c4 100644

--- a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

+++ b/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

@@ -174,7 +174,7 @@ void AutofillPopupViewViews::DrawAutofillEntry(gfx::Canvas* canvas,

if (controller_->selected_line() == index)

canvas->FillRect(entry_rect, kHoveredBackgroundColor);

- bool is_rtl = base::i18n::IsRTL();

+ bool is_rtl = controller_->is_rtl();

int value_text_width = controller_->GetNameFontForRow(index).GetStringWidth(

controller_->names()[index]);

int value_content_x = is_rtl ?