Issue 15769017: Fix EntryHookStub on ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15769017: Fix EntryHookStub on ia32 and x64. (Closed)

Created:
7 years, 6 months ago by Sigurður Ásgeirsson

Modified:
7 years, 6 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix EntryHookStub on ia32 and x64. These stubs were computing the return address location incorrectly. Add testing for same. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14962

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -22 lines)			Patch
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	4 chunks	+27 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

Sigurður Ásgeirsson

Hey Danno, this turned up while I was trying to finish up the profiler. Looks ...

7 years, 6 months ago (2013-06-05 18:56:06 UTC) #1

danno

7 years, 6 months ago (2013-06-05 21:02:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14962 (presubmit successful).