Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1576863003: [MD settings] correcting OnStartup text to match mocks (Closed)

Created:
4 years, 11 months ago by dschuyler
Modified:
4 years, 11 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] correcting OnStartup text to match mocks This CL brings the text labels up to date in the OnStartup settings. Some IDS text has been changed and some removed. note: The layout doesn't match the mocks yet, that will be done in a follow up CL. BUG=531750 Committed: https://crrev.com/8ce454e72c51fea1e7cc038eb8505a5e8a96e4b0 Cr-Commit-Position: refs/heads/master@{#368703}

Patch Set 1 #

Patch Set 2 : removed classes that are not available yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 11 months ago (2016-01-11 19:29:57 UTC) #2
dpapad
lgtm
4 years, 11 months ago (2016-01-11 19:58:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576863003/20001
4 years, 11 months ago (2016-01-11 22:23:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 23:09:10 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 23:10:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ce454e72c51fea1e7cc038eb8505a5e8a96e4b0
Cr-Commit-Position: refs/heads/master@{#368703}

Powered by Google App Engine
This is Rietveld 408576698