Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1576813003: X87: [date] Migrate Date field accessors to native builtins. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [date] Migrate Date field accessors to native builtins. port fc5c7e0486038f8a615041963a13c9b7bb602469 (r33172) original commit message: There's no reason to have JavaScript wrappers for those accessors, since the meat is already in hand-written native code (via %_DateField). First step now to put them into native builtins. Next step will be to completely remove %_DateField. BUG= Committed: https://crrev.com/a4bbe412143b0bf21742e78899591805bcbc6dd9 Cr-Commit-Position: refs/heads/master@{#33196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-11 02:05:18 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-11 09:46:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576813003/1
4 years, 11 months ago (2016-01-11 09:46:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 10:04:19 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 10:05:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4bbe412143b0bf21742e78899591805bcbc6dd9
Cr-Commit-Position: refs/heads/master@{#33196}

Powered by Google App Engine
This is Rietveld 408576698