Create a prelinker for summaries.

Create a prelinker for summaries.

The prelinker is capable of rebuilding the "Prelinked" summary
information based on the "Unlinked" information.  We will need to do
this in order to make efficient use of summaries when some files are
changed but not others, or when a pub package is upgraded but another
package that depends on it is left alone.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0b7c10e2b12c2b8fbf07dfbbe49dd7557b64bf23

[Paul Berry, 2016-01-10 02:11:39]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-01-10 05:15:12]

LGTM

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
2016 :-)

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:27: * unit.
The defining compilation unit of... which library?

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:474: for (var import in
units[0].imports) {
Type?

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_test.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_test.dart:142: String
resolveAbsoluteUri(LibraryElement library, String relativeUri) {
resolveToAbsoluteUri would be better maybe?

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_test.dart:149: return absoluteUri;
Could be inlined.

[Brian Wilkerson, 2016-01-10 16:45:27]

LGTM

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:36: * interpreted relative to the
defining compilation unit.
Ditto

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:38: * If no file exists at the given
uri, null should be returned.
nit: `null`

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/prelink_test.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/prelink_test.dart:1: // Copyright (c) 2015, the
Dart project authors.  Please see the AUTHORS file
2016

[Paul Berry, 2016-01-10 22:15:17]

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
On 2016/01/10 05:15:12, scheglov wrote:
> 2016 :-)

Done.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:27: * unit.
On 2016/01/10 05:15:12, scheglov wrote:
> The defining compilation unit of... which library?

The defining compilation unit of the library being prelinked.  I've updated this
comment (and the comment on GetPartCallback below) to reflect this.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:36: * interpreted relative to the
defining compilation unit.
On 2016/01/10 16:45:26, Brian Wilkerson wrote:
> Ditto

Done.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:38: * If no file exists at the given
uri, null should be returned.
On 2016/01/10 16:45:26, Brian Wilkerson wrote:
> nit: `null`

Done.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:474: for (var import in
units[0].imports) {
On 2016/01/10 05:15:12, scheglov wrote:
> Type?

Done.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/prelink_test.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/prelink_test.dart:1: // Copyright (c) 2015, the
Dart project authors.  Please see the AUTHORS file
On 2016/01/10 16:45:26, Brian Wilkerson wrote:
> 2016

Done.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_test.dart (right):

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_test.dart:142: String
resolveAbsoluteUri(LibraryElement library, String relativeUri) {
On 2016/01/10 05:15:12, scheglov wrote:
> resolveToAbsoluteUri would be better maybe?

Done.

https://codereview.chromium.org/1576743002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_test.dart:149: return absoluteUri;
On 2016/01/10 05:15:12, scheglov wrote:
> Could be inlined.

Done.

[Paul Berry, 2016-01-11 15:58:25]

Description was changed from

==========
Create a prelinker for summaries.

The prelinker is capable of rebuilding the "Prelinked" summary
information based on the "Unlinked" information.  We will need to do
this in order to make efficient use of summaries when some files are
changed but not others, or when a pub package is upgraded but another
package that depends on it is left alone.
==========

to

==========
Create a prelinker for summaries.

The prelinker is capable of rebuilding the "Prelinked" summary
information based on the "Unlinked" information.  We will need to do
this in order to make efficient use of summaries when some files are
changed but not others, or when a pub package is upgraded but another
package that depends on it is left alone.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0b7c10e2b12c2b8fbf07dfbbe49dd7557b64bf23
==========

[Paul Berry, 2016-01-11 15:58:26]

Committed patchset #1 (id:1) manually as
0b7c10e2b12c2b8fbf07dfbbe49dd7557b64bf23 (presubmit successful).