Use FlatBuffers for summaries.

Use FlatBuffers for summaries.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/68bf8244f80d18eaa7d21ff87dbe800072203acc

[Paul Berry, 2016-01-09 14:57:41]

lgtm assuming generation of toMap() is fixed.  Nicely done!

https://codereview.chromium.org/1576663002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/1576663002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:49: bool _uriIsSet = false;
Personally I would remove booleans like these (and the corresponding
assertions).  The only reason the old builder prohibited calling a setter more
than once was because I was thinking that when we transitioned to flatbuffers,
calling the setter would cause data to be written to the flatbuffer immediately.
 Now that we've decided to write to the flatbuffer from the finish() method,
there's no reason to prohibit calling the setter more than once; it just costs
memory and CPU cycles.

https://codereview.chromium.org/1576663002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:105: Map<String, Object> toMap() => {};
Looks like generation of this method got broken by this CL.  This will mess up
some some unit tests (they will appear to pass even if they are actually
failing).

[scheglov, 2016-01-09 18:55:07]

Description was changed from

==========
Use FlatBuffers for summaries.

R=paulberry@google.com
BUG=
==========

to

==========
Use FlatBuffers for summaries.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/68bf8244f80d18eaa7d21ff87dbe800072203acc
==========

[scheglov, 2016-01-09 18:55:08]

Committed patchset #2 (id:20001) manually as
68bf8244f80d18eaa7d21ff87dbe800072203acc (presubmit successful).

[scheglov, 2016-01-09 18:55:33]

https://codereview.chromium.org/1576663002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/1576663002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:49: bool _uriIsSet = false;
On 2016/01/09 14:57:41, Paul Berry wrote:
> Personally I would remove booleans like these (and the corresponding
> assertions).  The only reason the old builder prohibited calling a setter more
> than once was because I was thinking that when we transitioned to flatbuffers,
> calling the setter would cause data to be written to the flatbuffer
immediately.
>  Now that we've decided to write to the flatbuffer from the finish() method,
> there's no reason to prohibit calling the setter more than once; it just costs
> memory and CPU cycles.

Done.

https://codereview.chromium.org/1576663002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:105: Map<String, Object> toMap() => {};
On 2016/01/09 14:57:41, Paul Berry wrote:
> Looks like generation of this method got broken by this CL.  This will mess up
> some some unit tests (they will appear to pass even if they are actually
> failing).

Done.