third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js - Issue 1576613002: Update Google Input Tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js

Issue 1576613002: Update Google Input Tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing APIs, remove bade dependencies. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/google_input_tools/src/chrome/os/inputview/common.css ('k') | third_party/google_input_tools/src/chrome/os/inputview/config/constants.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js

diff --git a/third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js b/third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js

index 8ea94b1130a2f4985ad347ab36e21cc7c60d8cd1..603bdd29fb61180beb623684570800d5ce6e966b 100644

--- a/third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js

+++ b/third_party/google_input_tools/src/chrome/os/inputview/config/compact_util.js

@@ -15,10 +15,10 @@ goog.provide('i18n.input.chrome.inputview.content.compact.util');

goog.provide('i18n.input.chrome.inputview.content.compact.util.CompactKeysetSpec');

goog.require('goog.object');

+goog.require('i18n.input.chrome.ElementType');

goog.require('i18n.input.chrome.inputview.Css');

goog.require('i18n.input.chrome.inputview.SpecNodeName');

goog.require('i18n.input.chrome.inputview.content.Constants');

-goog.require('i18n.input.chrome.inputview.elements.ElementType');

goog.scope(function() {

var util = i18n.input.chrome.inputview.content.compact.util;

@@ -125,9 +125,10 @@ util.createCompactData = function(keysetSpec, viewIdPrefix, keyIdPrefix) {

util.createCompactKey = function(id, keySpec) {

var spec = keySpec;

spec[SpecNodeName.ID] = id;

- if (!spec[SpecNodeName.TYPE])

+ if (!spec[SpecNodeName.TYPE]) {

spec[SpecNodeName.TYPE] =

- i18n.input.chrome.inputview.elements.ElementType.COMPACT_KEY;

+ i18n.input.chrome.ElementType.COMPACT_KEY;

+ }

var newSpec = {};

for (var key in spec) {