Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/elements/content/charactermodel.js

Issue 1576613002: Update Google Input Tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing APIs, remove bade dependencies. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/google_input_tools/src/chrome/os/inputview/elements/content/charactermodel.js
diff --git a/third_party/google_input_tools/src/chrome/os/inputview/elements/content/charactermodel.js b/third_party/google_input_tools/src/chrome/os/inputview/elements/content/charactermodel.js
index 2655b2a8483f99eb7db8fc116df63858c486ad8b..ad98f62737606fa92ab3aefa6a669d089345e9dc 100644
--- a/third_party/google_input_tools/src/chrome/os/inputview/elements/content/charactermodel.js
+++ b/third_party/google_input_tools/src/chrome/os/inputview/elements/content/charactermodel.js
@@ -14,11 +14,13 @@
goog.provide('i18n.input.chrome.inputview.elements.content.CharacterModel');
goog.require('i18n.input.chrome.inputview.StateType');
+goog.require('i18n.input.chrome.inputview.util');
goog.scope(function() {
var StateType = i18n.input.chrome.inputview.StateType;
+var util = i18n.input.chrome.inputview.util;
@@ -181,13 +183,9 @@ CharacterModel.prototype.isVisible = function() {
* @private
*/
CharacterModel.prototype.toReversedCase_ = function() {
- var reversed;
- if (this.character_.toUpperCase() == this.character_) {
- reversed = this.character_.toLowerCase();
- } else {
- reversed = this.character_.toUpperCase();
- }
- return reversed;
+ var upper = util.toUpper(this.character_);
+ var lower = util.toLower(this.character_);
+ return (upper == this.character_) ? lower : upper;
};

Powered by Google App Engine
This is Rietveld 408576698