Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1576603002: Makes bindings work with nested message loops (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes bindings work with nested message loops Dispatching a message may result in a nested message loop. When dispatching a message we need to start a wait before dispatch, so that if a nested message loop does result we continue dispatching messages. BUG=none TEST=covered by tests. R=yzshen@chromium.org Committed: https://crrev.com/f8701563b0f1e831028676042eb59e2cd27374be Cr-Commit-Position: refs/heads/master@{#368608}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -35 lines) Patch
M mojo/public/cpp/bindings/lib/connector.cc View 1 1 chunk +16 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message.cc View 2 chunks +8 lines, -17 lines 0 comments Download
M mojo/public/cpp/bindings/message.h View 1 chunk +6 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 3 chunks +40 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
4 years, 11 months ago (2016-01-08 23:44:32 UTC) #1
yzshen1
LGTM with one comment Thanks! https://codereview.chromium.org/1576603002/diff/1/mojo/public/cpp/bindings/lib/connector.cc File mojo/public/cpp/bindings/lib/connector.cc (right): https://codereview.chromium.org/1576603002/diff/1/mojo/public/cpp/bindings/lib/connector.cc#newcode243 mojo/public/cpp/bindings/lib/connector.cc:243: WaitToReadMore(); Could you please ...
4 years, 11 months ago (2016-01-09 00:26:30 UTC) #2
sky
https://codereview.chromium.org/1576603002/diff/1/mojo/public/cpp/bindings/lib/connector.cc File mojo/public/cpp/bindings/lib/connector.cc (right): https://codereview.chromium.org/1576603002/diff/1/mojo/public/cpp/bindings/lib/connector.cc#newcode243 mojo/public/cpp/bindings/lib/connector.cc:243: WaitToReadMore(); On 2016/01/09 00:26:30, yzshen1 wrote: > Could you ...
4 years, 11 months ago (2016-01-11 16:10:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576603002/20001
4 years, 11 months ago (2016-01-11 16:11:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 17:17:13 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 17:18:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8701563b0f1e831028676042eb59e2cd27374be
Cr-Commit-Position: refs/heads/master@{#368608}

Powered by Google App Engine
This is Rietveld 408576698