runtime/vm/flow_graph_builder.cc - Issue 1576583003: More source position improvements and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1576583003: More source position improvements and tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index c0ffe2e2398189d8ef0f6b9db7b79630f3378b4c..8d0d10bf5b2c11a42587047e040fc013d940f3db 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -1218,7 +1218,7 @@ void EffectGraphVisitor::VisitReturnNode(ReturnNode* node) {

// <Expression> ::= Literal { literal: Instance }

void EffectGraphVisitor::VisitLiteralNode(LiteralNode* node) {

- ReturnDefinition(new(Z) ConstantInstr(node->literal()));

+ ReturnDefinition(new(Z) ConstantInstr(node->literal(), node->token_pos()));

}