More source position improvements and tests

More source position improvements and tests

- Provide source positions for some ConstantInstrs.
- Classify all other ConstantInstrs.
- Use the token position of ++ rather than x in the expr: "x++;" for the add, constant 1, and final load operations.
- More tests
- Improvements to the test helpers.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/3ca0a08117fb904fa75318d57c16e8ddb29365a2

[Cutch, 2016-01-08 23:34:48]

Description was changed from

==========
kjaskdfjksadjf

BUG=
==========

to

==========
More source position improvements and tests

- Provide source positions for some ConstantInstrs.
- Classify all other ConstantInstrs.
- Use the token position of ++ rather than x in the expr: "x++;" for the add,
constant 1, and final load operations.
- More tests
- Improvements to the test helpers.
==========

[Cutch, 2016-01-08 23:34:48]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-01-09 00:35:57]

lgtm w/c

https://codereview.chromium.org/1576583003/diff/1/runtime/vm/flow_graph_build...
File runtime/vm/flow_graph_builder_test.cc (right):

https://codereview.chromium.org/1576583003/diff/1/runtime/vm/flow_graph_build...
runtime/vm/flow_graph_builder_test.cc:263:
spt.FuzzyInstructionMatchAt("LoadStaticField", 5, 12);
Missing return and debug step check for 'return x'

[Cutch, 2016-01-11 18:12:48]

https://codereview.chromium.org/1576583003/diff/1/runtime/vm/flow_graph_build...
File runtime/vm/flow_graph_builder_test.cc (right):

https://codereview.chromium.org/1576583003/diff/1/runtime/vm/flow_graph_build...
runtime/vm/flow_graph_builder_test.cc:263:
spt.FuzzyInstructionMatchAt("LoadStaticField", 5, 12);
On 2016/01/09 00:35:56, rmacnak wrote:
> Missing return and debug step check for 'return x'

Done.

[Cutch, 2016-01-11 18:19:14]

Description was changed from

==========
More source position improvements and tests

- Provide source positions for some ConstantInstrs.
- Classify all other ConstantInstrs.
- Use the token position of ++ rather than x in the expr: "x++;" for the add,
constant 1, and final load operations.
- More tests
- Improvements to the test helpers.
==========

to

==========
More source position improvements and tests

- Provide source positions for some ConstantInstrs.
- Classify all other ConstantInstrs.
- Use the token position of ++ rather than x in the expr: "x++;" for the add,
constant 1, and final load operations.
- More tests
- Improvements to the test helpers.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3ca0a08117fb904fa75318d57c16e8ddb29365a2
==========

[Cutch, 2016-01-11 18:19:15]

Committed patchset #3 (id:40001) manually as
3ca0a08117fb904fa75318d57c16e8ddb29365a2 (presubmit successful).