Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1576563002: [Media Router] Replace old MR extension ID with "new" extension ID. (Closed)

Created:
4 years, 11 months ago by imcheng
Modified:
4 years, 11 months ago
Reviewers:
Devlin, brettw, xhwang, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, pfeldman+blink_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, pfeldman, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Replace old MR extension ID with "new" extension ID. Search and replace of all occurrences of the current MR extension ID with the new one we would like to use. The extensions will be identical. Since we haven't enabled Media Router there is no impact on existing users. Please see bug for additional background/details. BUG=574889 Committed: https://crrev.com/5013c5834fcff9558ac62bbfeb4615435dca735e Cr-Commit-Position: refs/heads/master@{#368966}

Patch Set 1 #

Messages

Total messages: 16 (7 generated)
imcheng
Reviewers, PTAL: rdevlin.cronin: chrome/browser/extensions/*, chrome/common/extensions/*, extensions/common/* brettw: extension_view_whitelist.cc xhwang: chrome/browser/media/media_capture_devices_dispatcher.cc pfeldman: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
4 years, 11 months ago (2016-01-11 18:54:53 UTC) #5
brettw
extension_view_whitelist LGTM
4 years, 11 months ago (2016-01-11 19:01:07 UTC) #6
xhwang
chrome/browser/media/media_capture_devices_dispatcher.cc rs lgtm
4 years, 11 months ago (2016-01-11 19:17:36 UTC) #7
Devlin
rs lgtm. Shame we can't use the constant in more of those places.
4 years, 11 months ago (2016-01-11 20:27:03 UTC) #8
imcheng
Ping for pfeldman.
4 years, 11 months ago (2016-01-12 18:20:01 UTC) #9
pfeldman
lgtm
4 years, 11 months ago (2016-01-12 18:44:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576563002/1
4 years, 11 months ago (2016-01-12 18:45:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 20:10:32 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 20:11:21 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5013c5834fcff9558ac62bbfeb4615435dca735e
Cr-Commit-Position: refs/heads/master@{#368966}

Powered by Google App Engine
This is Rietveld 408576698