Pseudo element selectors in compound selector lists are invalid.

Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481, 393490
Committed: https://crrev.com/83f990eecc65eaed30f45db7e1649898c1e7076d
Cr-Commit-Position: refs/heads/master@{#368823}

[rune, 2016-01-08 21:54:41]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 21:55:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576553002/1

[commit-bot: I haz the power, 2016-01-09 00:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-09 00:36:44]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-01-11 05:20:54]

The spec doesn't seem to explicitly disallow this?

https://drafts.csswg.org/selectors/#matches-pseudo
"Pseudo-elements [..] are not valid within :matches()."

https://drafts.csswg.org/css-scoping/#selectordef-host-context
-> no restriction?

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp:109:
DisallowPseudoElementsScope scope(this);
I think it would make more sense for this to be at the call-sites to this
function.

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
(right):

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:153: for
(unsigned i = 0; i < WTF_ARRAY_LENGTH(testCases); ++i) {
range-based for loop? :)

[rune, 2016-01-11 08:38:39]

On 2016/01/11 05:20:54, Timothy Loh wrote:
> The spec doesn't seem to explicitly disallow this?
> 
> https://drafts.csswg.org/selectors/#matches-pseudo
> "Pseudo-elements [..] are not valid within :matches()."
> 
> https://drafts.csswg.org/css-scoping/#selectordef-host-context
> -> no restriction?

No, but it seems it should have been:

https://lists.w3.org/Archives/Public/www-style/2014Jul/0486.html

Also, see crbug.com/393490

[rune, 2016-01-11 08:38:58]

Description was changed from

==========
Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481
==========

to

==========
Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481,393490
==========

[rune, 2016-01-11 09:30:23]

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp:109:
DisallowPseudoElementsScope scope(this);
On 2016/01/11 05:20:54, Timothy Loh wrote:
> I think it would make more sense for this to be at the call-sites to this
> function.

Done.

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
(right):

https://codereview.chromium.org/1576553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:153: for
(unsigned i = 0; i < WTF_ARRAY_LENGTH(testCases); ++i) {
On 2016/01/11 05:20:54, Timothy Loh wrote:
> range-based for loop? :)

Done.

[rune, 2016-01-11 09:49:21]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 09:49:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576553002/40001

[commit-bot: I haz the power, 2016-01-11 10:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 10:55:31]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-01-12 01:52:31]

On 2016/01/11 08:38:39, rune wrote:
> On 2016/01/11 05:20:54, Timothy Loh wrote:
> > The spec doesn't seem to explicitly disallow this?
> > 
> > https://drafts.csswg.org/selectors/#matches-pseudo
> > "Pseudo-elements [..] are not valid within :matches()."
> > 
> > https://drafts.csswg.org/css-scoping/#selectordef-host-context
> > -> no restriction?
> 
> No, but it seems it should have been:
> 
> https://lists.w3.org/Archives/Public/www-style/2014Jul/0486.html
> 
> Also, see crbug.com/393490

lgtm

[rune, 2016-01-12 07:36:06]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-01-12 07:36:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576553002/40001

[commit-bot: I haz the power, 2016-01-12 08:41:31]

Description was changed from

==========
Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481,393490
==========

to

==========
Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481,393490
==========

[commit-bot: I haz the power, 2016-01-12 08:41:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 08:42:47]

Description was changed from

==========
Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481,393490
==========

to

==========
Pseudo element selectors in compound selector lists are invalid.

These selectors were never matching, but they are invalid and rules with
invalid selectors should not show up in the CSSOM.

This is just partly fixing detection of invalid use of pseudo elements.
We also incorrectly accept simple selectors following pseudo elements.
In most cases those are invalid selectors.

The modified existing cases contained invalid selectors and they were
modified to make them valid for serialization testing purposes.

R=timloh@chromium.org
BUG=489481,393490

Committed: https://crrev.com/83f990eecc65eaed30f45db7e1649898c1e7076d
Cr-Commit-Position: refs/heads/master@{#368823}
==========

[commit-bot: I haz the power, 2016-01-12 08:42:48]

Patchset 3 (id:??) landed as
https://crrev.com/83f990eecc65eaed30f45db7e1649898c1e7076d
Cr-Commit-Position: refs/heads/master@{#368823}